Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Change *_mkldnn* test and build scenarios names to *_onednn* #20034

Merged
merged 2 commits into from
Mar 24, 2021
Merged

Change *_mkldnn* test and build scenarios names to *_onednn* #20034

merged 2 commits into from
Mar 24, 2021

Conversation

bartekkuncer
Copy link
Contributor

@bartekkuncer bartekkuncer commented Mar 16, 2021 •
edited
Loading

Description

This change changes _mkldnn test and build scenarios names to _onednn.

Checklist

Changes

  • Change scenarios names
  • Change names of created in Jenkins files instances of mxnet using onednn
  • Change return strings from scenarios
  • Change workspace names in scenarios

@mxnet-bot
Copy link

Hey @bartekkuncer , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [unix-gpu, miscellaneous, website, windows-gpu, windows-cpu, clang, sanity, edge, centos-cpu, centos-gpu, unix-cpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added the pr-awaiting-testing PR is reviewed and waiting CI build and test label Mar 16, 2021
@bartekkuncer bartekkuncer marked this pull request as draft March 16, 2021 12:18
@bartekkuncer bartekkuncer changed the title Change *_mkldnn* test and build scenarios names to *_onednn* [DRAFT] Change *_mkldnn* test and build scenarios names to *_onednn* Mar 16, 2021
@lanking520 lanking520 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Mar 16, 2021
@bartekkuncer
Copy link
Contributor Author

@mxnet-bot run ci [unix-cpu,windows-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-cpu, unix-cpu]

anko-intel
anko-intel reviewed Mar 16, 2021
View reviewed changes
ci/jenkins/Jenkins_steps.groovy Outdated Show resolved Hide resolved
ci/jenkins/Jenkinsfile_unix_cpu Outdated Show resolved Hide resolved
@bartekkuncer
Copy link
Contributor Author

@mxnet-bot run ci [unix-cpu,windows-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-cpu, windows-cpu]

@bartekkuncer bartekkuncer marked this pull request as ready for review March 17, 2021 12:24
@bartekkuncer bartekkuncer changed the title [DRAFT] Change *_mkldnn* test and build scenarios names to *_onednn* Change *_mkldnn* test and build scenarios names to *_onednn* Mar 17, 2021
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Mar 17, 2021
@bartekkuncer
Copy link
Contributor Author

@mxnet-bot run ci [centos-cpu,windows-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [centos-cpu, windows-cpu]

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Mar 17, 2021
@bartekkuncer
Copy link
Contributor Author

bartekkuncer commented Mar 17, 2021 •
edited
Loading

@szha @leezu Please help with the merge :)

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-awaiting-review PR is waiting for code review pr-awaiting-testing PR is reviewed and waiting CI build and test labels Mar 18, 2021
@bartekkuncer
Copy link
Contributor Author

@szha @leezu As I have resolved the merge problem please help with the merge.

@bartekkuncer
Copy link
Contributor Author

@szha @leezu Is something blocking the merge of this PR? If so can I help with resolving the problem?

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review pr-work-in-progress PR is still work in progress and removed pr-awaiting-review PR is waiting for code review pr-awaiting-testing PR is reviewed and waiting CI build and test labels Mar 22, 2021
@bartekkuncer
Copy link
Contributor Author

@mxnet-bot run ci [windows-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-cpu]

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Mar 22, 2021
@bartekkuncer
Copy link
Contributor Author

@szha Is there something blocking this PR?

@leezu leezu merged commit c7a8ccc into apache:master Mar 24, 2021
@leezu
Copy link
Contributor

leezu commented Mar 24, 2021

Is there something blocking this PR?

No :) Sorry for the delay

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anko-intel anko-intel anko-intel left review comments

@szha szha szha left review comments

@leezu leezu leezu left review comments

@aaronmarkham aaronmarkham Awaiting requested review from aaronmarkham aaronmarkham is a code owner

@marcoabreu marcoabreu Awaiting requested review from marcoabreu marcoabreu is a code owner

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bartekkuncer @mxnet-bot @leezu @szha @anko-intel @lanking520